Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add linearity test for istft #279

Merged
merged 5 commits into from
Oct 31, 2019
Merged

add linearity test for istft #279

merged 5 commits into from
Oct 31, 2019

Conversation

swchen1234
Copy link
Contributor

Add four test cases of linearity check for inverse stft in test_functional.py.

@swchen1234
Copy link
Contributor Author

@pytorchbot retest this please

vincentqb
vincentqb reviewed Sep 16, 2019
View reviewed changes
test/test_functional.py Outdated Show resolved Hide resolved
@engineerchuan
Copy link
Contributor

We recently added retries to the build process to be robust to network timeouts. That seems to be why the tests failed, versus anything wrong with your test itself.

@vincentqb vincentqb closed this Sep 16, 2019
@vincentqb vincentqb reopened this Sep 16, 2019
vincentqb
vincentqb reviewed Sep 16, 2019
View reviewed changes
test/test_functional.py Outdated Show resolved Hide resolved
@vincentqb
Copy link
Contributor

Can you rebase your changes on master? There seems to be changes that are not available here. In particular, if you look at the error logs, curl is called without retry, see here.

vincentqb
vincentqb reviewed Sep 17, 2019
View reviewed changes
test/test_functional.py Outdated Show resolved Hide resolved
@swchen1234
Copy link
Contributor Author

still gets lots of Failed to connect to downloads.sourceforge.net port 80: Operation timed out failure.

@vincentqb
Copy link
Contributor

vincentqb commented Sep 17, 2019 •
edited

still gets lots of Failed to connect to downloads.sourceforge.net port 80: Operation timed out failure.

Have you rebased on pytorch/audio's master? It seems like your version doesn't have the curl fix, see yours vs pytorch/audio's.

@vincentqb
Copy link
Contributor

flake8 and rebased

vincentqb
vincentqb approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for working on this!

@vincentqb
Copy link
Contributor

One test needs to be relaxed from atol=1e-6 to atol=1e-5.

@vincentqb vincentqb merged commit 2489cbb into pytorch:master Oct 31, 2019
@vincentqb
Copy link
Contributor

pytorch/pytorch#3775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swchen1234 @engineerchuan @vincentqb