Enable log probs input for rnnt loss #2798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolineechen
force-pushed
the
rnntl-log-probs
branch
from
c78360e
to
9ce76a2
Compare
carolineechen
force-pushed
the
rnntl-log-probs
branch
from
9ce76a2
to
3f00a4b
Compare
carolineechen
force-pushed
the
rnntl-log-probs
branch
from
3f00a4b
to
68664dc
Compare
carolineechen
changed the title
xiaohui-zhang
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
LGTM. thanks @carolineechen for addressing this quickly to unblock @BriansIDP !
|
@carolineechen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@carolineechen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
reviewed
Nov 7, 2022
mthrok
approved these changes
Nov 7, 2022
carolineechen
force-pushed
the
rnntl-log-probs
branch
from
ca0c8a5
to
2b3cdc3
Compare
|
@carolineechen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @carolineechen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
fused_log_softmaxargument (default/current behavior = True) to rnnt loss.If setting it to
False, calllog_softmaxon the logits prior to passing it in to the rnnt loss function.The following should produce the same output:
testing -- unit tests + get same results on the conformer rnnt recipe