Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitch detection #313

Merged
merged 20 commits into from
Oct 30, 2019
Merged

Pitch detection #313

merged 20 commits into from
Oct 30, 2019

Conversation

vincentqb
Copy link
Contributor

@vincentqb vincentqb commented Oct 24, 2019

Since the pitch is important in translating languages such as mandarin, we want a pitch detection algorithm. See also notebook.

We implement this using normalized cross-correlation function (NCCF) and median smoothing, mentioned in RAPT. Kaldi also uses NCCF, but uses an algorithm based on viterbi instead of median smoothing for smoothing, see here.

  • Both pure tones from here are detected successfully.
  • Move out of example

Closes #257

@cpuhrsch
Copy link
Contributor

Would these transforms already work with @torch.jit.script ? :)

@vincentqb
Copy link
Contributor Author

Would these transforms already work with @torch.jit.script ? :)

Yup :)

@vincentqb vincentqb merged commit 26237c8 into pytorch:master Oct 30, 2019
@vincentqb vincentqb deleted the pitch branch October 30, 2019 13:56
@PetrochukM
Copy link

What's the difference between this and something like CREPE, pYIN and SPICE? Which is best to use for a typical voice-over?

@vincentqb
Copy link
Contributor Author

vincentqb commented Oct 19, 2020

What's the difference between this and something like CREPE, pYIN and SPICE? Which is best to use for a typical voice-over?

The algorithm included here is a non-neural-network algorithm (based on RAPT, and related to Kaldi's) to identify pitch that can be used as a baseline. The algorithms you mention look promising, but I'd simply experiment and find what's best for a particular case :) Is that what you meant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fundamental Frequency
3 participants