Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify helper function #514

Merged
merged 1 commit into from Apr 6, 2020
Merged

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 6, 2020

Batch test helper can be simpler with Pythonic expression.
The default value of atol and rtol are teken from the downstream function here.

@mthrok mthrok requested a review from vincentqb April 6, 2020 18:00
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb vincentqb merged commit bc1ffb1 into pytorch:master Apr 6, 2020
@mthrok mthrok deleted the cleanup-batch-test-1 branch April 6, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants