Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup batch test #519

Merged
merged 1 commit into from Apr 7, 2020
Merged

Cleanup batch test #519

merged 1 commit into from Apr 7, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 7, 2020

The helper functions in batch test have duplicated code and confusing names. This PR refactors them and improve the readability (thus maintainability).

@mthrok mthrok requested a review from vincentqb April 7, 2020 15:10
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb vincentqb merged commit 657f0a0 into pytorch:master Apr 7, 2020
@mthrok mthrok deleted the cleanup-batch-test branch April 7, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants