Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline typing utils dataset #522

Merged
merged 8 commits into from Apr 7, 2020
Merged

Inline typing utils dataset #522

merged 8 commits into from Apr 7, 2020

Conversation

tomassosorio
Copy link
Contributor

@tomassosorio tomassosorio commented Apr 7, 2020 •
edited

add inline typing to utils dataset and common_utils
relates to: #477

vincentqb
vincentqb approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb vincentqb merged commit 4e5ee9f into pytorch:master Apr 7, 2020
@tomassosorio tomassosorio deleted the InlineTypingUtilsDataset branch April 7, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomassosorio @vincentqb