Simplify and abstract away asset access in test #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims the following things; 1. Introduce and adopt helper function `get_asset_path` that abstract the logic to construct path to test assets. 2. Remove `create_temp_assets_dir` anywhere except `test_io`. The benefits of doing so are, a. the test code becomes simpler (no manual construction of asset path with `os.path.join`) b. No unnecessary directory creation and file copies. For 2. and b. tests in `test_io.py` (or tests that use `torchaudio.save`) are the only tests that need to write file to the disc, where the use of temporary directory makes it cleaner, therefore, `create_temp_assets_dir` is not necessary elsewhere. (still, `test_io` does not need to copy the entire asset directory, but that's not the point here.) Also if any test is accidentally overwriting an asset data, not using a copy will make us aware of such behavior, so it is better to get rid of `create_temp_assets_dir`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims the following things;
get_asset_paththat abstract the logic to construct path to test assets.create_temp_assets_diranywhere excepttest_io.The benefits of doing so are,
a. the test code becomes simpler (no manual construction of asset path with
os.path.join)b. No unnecessary directory creation and file copies.
For 2. and b. tests in
test_io.py(or tests that usetorchaudio.save) are the only tests that need to write file to the disc, where the use of temporary directory makes it cleaner, therefore,create_temp_assets_diris not necessary elsewhere. (still,test_iodoes not need to copy the entire asset directory, but that's not the point here.)Also if any test is accidentally overwriting an asset data, not using a copy will make us aware of such behavior, so it is better to get rid of
create_temp_assets_dir.