Fix inline typing for mypy #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomassosorio
changed the title
tomassosorio
force-pushed
the
fixInlineTypingForMypy
branch
from
e6883f4
to
551eb29
Compare
tomassosorio
changed the title
vincentqb
suggested changes
Apr 15, 2020
| @@ -168,13 +168,13 @@ def save_encinfo(filepath: str, | |||
| # sox stores the sample rate as a float, though practically sample rates are almost always integers | |||
| # convert integers to floats | |||
| if signalinfo: | |||
| if not isinstance(signalinfo.rate, float): | |||
| if signalinfo.rate and not isinstance(signalinfo.rate, float): | |||
There was a problem hiding this comment.
This is trying to avoid converting signalinfo.rate when it's zero?
There was a problem hiding this comment.
actually this is due to SignalInfo is defined as None in its variables.
So this will check if the variable exists if so then will check if the variable isinstance float
| if float(signalinfo.rate) == signalinfo.rate: | ||
| signalinfo.rate = float(signalinfo.rate) | ||
| else: | ||
| raise TypeError('Sample rate should be a float or int') | ||
| # check if the bit precision (i.e. bits per sample) is an integer | ||
| if not isinstance(signalinfo.precision, int): | ||
| if signalinfo.precision and not isinstance(signalinfo.precision, int): |
| from torch.utils.data import Dataset | ||
| from torch.utils.model_zoo import tqdm | ||
|
|
||
|
|
||
| def unicode_csv_reader(unicode_csv_data: TextIOWrapper, **kwargs: Any) -> str: | ||
| def unicode_csv_reader(unicode_csv_data: TextIOWrapper, **kwargs: Any) -> Any: |
There was a problem hiding this comment.
This is not BC breaking yet since the inline typing isn't part of the release. str was added in here.
There was a problem hiding this comment.
This was changed due to csv.reader has as output Any instead of str so this function actually will give Any and not solely str has output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #477
This should fix all mypy issues and could be used to check if PR follow all its agreements running:
mypy torchaudio/getting:
Success: no issues found in 19 source files