Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend change instructions in readme #553

Merged
merged 2 commits into from May 14, 2020

Conversation

vincentqb
Copy link
Contributor

Show the instructions on how to switch the backend amongst available ones, in the readme.

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we want to mention SoundFile being only backend available for Windows?

By default in OSX and Linux, torchaudio uses SoX as a backend to load and save files.
The backend can be changed to [SoundFile](https://pysoundfile.readthedocs.io/en/latest/)
using the following. See [SoundFile](https://pysoundfile.readthedocs.io/en/latest/)
for installation instructions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest providing some more information here specific to pip and conda. You can directly link to the package on pypi for example to avoid confusion with projects such as sndfile, which is the name used by the underlying libsndfile.

@cpuhrsch cpuhrsch requested a review from mthrok April 29, 2020 02:25
@vincentqb vincentqb merged commit adb3d3d into pytorch:master May 14, 2020
bhargavkathivarapu pushed a commit to bhargavkathivarapu/audio that referenced this pull request May 19, 2020
* backend change instructions in readme.

* link to installation instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants