Improve lfilter speed #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Total time: 13.7078 ``` 722| 220501| 2.44247| 1.10769e-05| 17.82%| for i_sample, o0 in enumerate(input_signal_windows.t()): (call)| 1| 6.36578e-05| 6.36578e-05| 0.00%|# /scratch/moto/pytorch/torch/tensor.py:460 __iter__ (call)| 220500| 1.60566| 7.28191e-06| 11.71%|# /scratch/moto/pytorch/torch/tensor.py:474 <lambda> 723| 220500| 1.86697| 8.46698e-06| 13.62%| windowed_output_signal = padded_output_waveform[:, i_sample:(i_sample + n_order)] 724| 220500| 1.94628| 8.82669e-06| 14.20%| o0.addmv_(windowed_output_signal, a_coeffs_flipped, alpha=-1) 725| 220500| 2.46| 1.11565e-05| 17.94%| o0.div_(a_coeffs[0]) 726| 0| 0| 0| 0.00%| 727| 220500| 3.37869| 1.53229e-05| 24.64%| padded_output_waveform[:, i_sample + n_order - 1] = o0 ``` After Total time: 10.9667 ``` 722| 1| 9.2268e-05| 9.2268e-05| 0.00%| input_signal_windows.div_(a_coeffs[0]) 723| 1| 2.14577e-05| 2.14577e-05| 0.00%| a_coeffs_flipped.div_(a_coeffs[0]) 724| 220501| 2.40216| 1.08941e-05| 21.90%| for i_sample, o0 in enumerate(input_signal_windows.t()): (call)| 1| 5.84126e-05| 5.84126e-05| 0.00%|# /scratch/moto/pytorch/torch/tensor.py:460 __iter__ (call)| 220500| 1.59821| 7.2481e-06| 14.57%|# /scratch/moto/pytorch/torch/tensor.py:474 <lambda> 725| 220500| 1.82273| 8.26633e-06| 16.62%| windowed_output_signal = padded_output_waveform[:, i_sample:(i_sample + n_order)] 726| 220500| 1.84074| 8.34802e-06| 16.78%| o0.addmv_(windowed_output_signal, a_coeffs_flipped, alpha=-1) 727| 220500| 3.2952| 1.49442e-05| 30.05%| padded_output_waveform[:, i_sample + n_order - 1] = o0 ```
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
* Update requirements.txt Pinning sphinx gallery. Step one. Please don't merge. * Update build.sh removed audio, audio sample, added || true to line 39. * Update build.sh uninstall/install awscli * Update build.sh Trying to unpin Sphinx from ==1.8.2. * Update build.sh Pinning sphinx-gallery. * Update build.sh repining sphinx trying pip install * Update build.sh removed -y option * Update build.sh * Update build.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
lfilterspeed by 10%. See #517 for the script to measure the line by line execution time.Before
Total time: 13.7078
After
Total time: 10.9667