Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overdrive to functional #569

Merged
merged 6 commits into from Apr 22, 2020

Conversation

bhargavkathivarapu
Copy link
Contributor

Hi ,
Regarding the issue #260 ( Reducing dependency in Sox)
Implemented overdrive function in functional.py

  • function.rst - updated with new fucntion

  • test_sox_compatibility.py - Added a test for overdrive . Tests passed

...................gain: can't reclaim headroom
.
----------------------------------------------------------------------
Ran 20 tests in 509.658s

OK
  • test_torchscript_consistency.py - added test . Test passed
...................................sssssssssssssssssssssssssssssssssss................ssssssssssssssss
----------------------------------------------------------------------
Ran 102 tests in 1400.141s

OK (skipped=51)
  • test_batch_consistency.py - added test for overdrive . Test for overdrive passed, but
    existing batch_mfcc failed
...............F..
======================================================================
FAIL: test_batch_mfcc (__main__.TestTransforms)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_batch_consistency.py", line 201, in test_batch_mfcc
    torch.testing.assert_allclose(computed, expected, atol=1e-5, rtol=1e-5)
  File "/Users/ka387861/pytorch/torch/testing/__init__.py", line 59, in assert_allclose
    count - 1, 100 * count / actual.numel()))
AssertionError: Not within tolerance rtol=1e-05 atol=1e-05 at input[2, 0, 2, 1384] (0.5488258004188538 vs. 0.5488020181655884) and 8 other locations (0.00%)

----------------------------------------------------------------------
Ran 18 tests in 185.586s

For making the torch script test work i added a redundant operation .
Comment mentioning that is present in code.

@vincentqb could you please review these changes

@mthrok mthrok requested review from vincentqb and mthrok and removed request for vincentqb April 21, 2020 15:23
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. Mostly looks good!.

torchaudio/functional.py Show resolved Hide resolved
torchaudio/functional.py Outdated Show resolved Hide resolved
torchaudio/functional.py Outdated Show resolved Hide resolved
torchaudio/functional.py Show resolved Hide resolved
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@vincentqb vincentqb merged commit e7cb18c into pytorch:master Apr 22, 2020
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants