Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop build binary for Python3.5 #577

Merged
merged 1 commit into from Apr 23, 2020
Merged

Stop build binary for Python3.5 #577

merged 1 commit into from Apr 23, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 23, 2020

PyTorch master has dropped support for Python 3.5 but torch audio is still building binary for Python 3.5.
Not sure if intended. Can you advise? @seemethere @soumith @ezyang

@vincentqb
Copy link
Contributor

vincentqb commented Apr 23, 2020 •
edited

The blog post for 1.5.0 still mentions python 3.5, see here.

Link also to internal discussion.

seemethere
seemethere approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb
Copy link
Contributor

@mthrok -- can you rebase and merge?

@mthrok
Copy link
Collaborator Author

mthrok commented Apr 23, 2020

@vincentqb Rebased.

@seemethere I have a question regarding the image build job relies on. pytorch/manylinux-cuda100 Is it just a build environment or does it contain PyTorch installation? I noticed that the latest image was uploaded one month ago. So I am guessing that's not nightly build of PyTorch, and wanted to make sure that torchaudio is not build in an env where an old PyTorch presents.

@mthrok
Copy link
Collaborator Author

mthrok commented Apr 23, 2020

Haven't seen all green for a while haha.

@seemethere
Copy link
Member

@seemethere I have a question regarding the image build job relies on. pytorch/manylinux-cuda100 Is it just a build environment or does it contain PyTorch installation? I noticed that the latest image was uploaded one month ago. So I am guessing that's not nightly build of PyTorch, and wanted to make sure that torchaudio is not build in an env where an old PyTorch presents.

It is just a development environment and it does not contain a copy of any PyTorch release inside of it.

The build files for that particular docker image are here: https://github.com/pytorch/builder/blob/master/manywheel/Dockerfile

@vincentqb vincentqb merged commit 14cc5c0 into pytorch:master Apr 23, 2020
@mthrok mthrok deleted the cleanup-cci2 branch April 23, 2020 23:55
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
@brianjo
Merge pull request pytorch#577 from jiangzhonglian/master
8816366 
chatbot_tutorial.py:   Solve the optimizer cuda call problem
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
@bddppq @soumith
Fix ProgressMeter usage in imagenet validation (pytorch#577)
1de2ff9 
pytorch/examples@2ea9f6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@soumith soumith Awaiting requested review from soumith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mthrok @vincentqb @seemethere