Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA test on CCI #586

Merged
merged 2 commits into from May 6, 2020
Merged

Add CUDA test on CCI #586

merged 2 commits into from May 6, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 24, 2020

This PR adds CUDA-enabled unit test to CCI workflow.
GPU-enabled test only runs on master branch. (after PR is merged.)
(If we want to run the test for all the PR, I am open to it.)

See here for the resulting CUDA test.

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #586 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files          21       21           
  Lines        2254     2254           
=======================================
  Hits         2006     2006           
  Misses        248      248           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71b5ee...851f8e2. Read the comment docs.

@mthrok mthrok force-pushed the test-gpu branch 26 times, most recently from 7fe6814 to eaf3f31 Compare May 5, 2020 02:01
@mthrok mthrok changed the title [Draft] Run CUDA test on CCI. Add CUDA test on CCI May 5, 2020
@mthrok mthrok requested a review from vincentqb May 5, 2020 21:43
@mthrok mthrok marked this pull request as ready for review May 5, 2020 21:43
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to run this on master only for now.

@@ -1 +1,2 @@
scripts/build_third_parties.sh
Dockerfile.tmp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not sure it's quite related, but ok :)

@vincentqb vincentqb merged commit 867d669 into pytorch:master May 6, 2020
@mthrok mthrok deleted the test-gpu branch May 6, 2020 15:46
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants