Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phaser to functional #587

Merged
merged 1 commit into from May 1, 2020
Merged

Conversation

bhargavkathivarapu
Copy link
Contributor

Hi ,
Regarding the issue ( Reducing dependency in Sox - #260 )
Implemented phaser function in functional.py

  • function.rst - updated with new function

  • test_sox_compatibility.py - Added two tests for phaser

  • test_batch_consistency.py - added test for phaser

  • test_torchscript_consistency.py - added test for phaser

All CPU test passed.

@vincentqb could you please review these changes

Signed-off-by: Bhargav Kathivarapu <bhargavkathivarapu31@gmail.com>
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #587 into master will increase coverage by 0.17%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   87.85%   88.03%   +0.17%     
==========================================
  Files          19       19              
  Lines        2051     2097      +46     
==========================================
+ Hits         1802     1846      +44     
- Misses        249      251       +2     
Impacted Files Coverage Δ
torchaudio/functional.py 94.85% <95.65%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc591e...d5768f9. Read the comment docs.

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@vincentqb vincentqb merged commit 8e81359 into pytorch:master May 1, 2020
@mthrok
Copy link
Collaborator

mthrok commented May 4, 2020

@mthrok
Copy link
Collaborator

mthrok commented May 4, 2020

Fix -> #607

mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants