Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mypy Variable Typing #590

Merged
merged 1 commit into from May 5, 2020
Merged

Fix Mypy Variable Typing #590

merged 1 commit into from May 5, 2020

Conversation

tomassosorio
Copy link
Contributor

Mypy detected _SOX_INITIALIZED merely as bool, however, can be None as well

@codecov
Copy link

codecov bot commented Apr 27, 2020 •
edited

Codecov Report

Merging #590 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   87.85%   87.85%           
=======================================
  Files          19       19           
  Lines        2051     2051           
=======================================
  Hits         1802     1802           
  Misses        249      249
Impacted Files Coverage Δ
torchaudio/__init__.py 78.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3012050...03596f0. Read the comment docs.

vincentqb
vincentqb approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vincentqb vincentqb merged commit b71b5ee into pytorch:master May 5, 2020
@tomassosorio tomassosorio deleted the MypyErrorFix branch May 5, 2020 20:37
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
@brianjo
Merge pull request pytorch#590 from pytorch/torchvision-patch-1
3fde079 
Update torchvision_tutorial.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomassosorio @vincentqb