Revert "replace reshape by view" #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 60fd113.
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
=======================================
Coverage 88.69% 88.70%
=======================================
Files 21 21
Lines 2203 2204 +1
=======================================
+ Hits 1954 1955 +1
Misses 249 249
Continue to review full report at Codecov.
|
vincentqb
approved these changes
Apr 29, 2020
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
[WIP] Torchtext Update for build.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #409
We can use view instead of reshape if we are certain that the to-be-viewed Tensor is always shape compliant with the target shape, which won't necessarily apply to input Tensors. The advantage is that we'll always avoid a copy and can be sure to not incur a copy (lest we get the referenced error). Let's revert this change that was implemented due to my comment. Thank you following up on this Vincent!