Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audio samples for vad testing #599

Merged
merged 1 commit into from Apr 30, 2020

Conversation

astaff
Copy link
Contributor

@astaff astaff commented Apr 30, 2020

This PR re-uses sample test/assets/SpeechCommands/speech_commands_v0.02/go/0a9f9af7_nohash_0.wav to produce stereo and mono samples for vad.

@mthrok
Copy link
Collaborator

mthrok commented Apr 30, 2020

Although these files are small, if data are coming from existing file, I prefer to generate such data on the fly during the test. If we keep adding test assets, the size of repository increases, and that could be problematic at some point for downstream users.

@vincentqb vincentqb merged commit b457cb7 into pytorch:master Apr 30, 2020
@astaff
Copy link
Contributor Author

astaff commented Apr 30, 2020

Although these files are small, if data are coming from existing file, I prefer to generate such data on the fly during the test. If we keep adding test assets, the size of repository increases, and that could be problematic at some point for downstream users.

Agreed. Maybe this is something that can be mentioned in how to contribute along with the right way to manage temporary files in the test suite. unittest and pytest have different approaches, as far as I understand.

@jeffreyksmithjr
Copy link

It also seems possible to maintain a small library of test data, if we think we can keep cover all uses cases with a sufficiently small collection.

Alternatively, pulling down datasets from a network location would be another option, but it introduces other complications that make unit tests more like integration tests.

mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants