Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lfilter: add an optional arg clamp #600

Merged
merged 4 commits into from Apr 30, 2020
Merged

lfilter: add an optional arg clamp #600

merged 4 commits into from Apr 30, 2020

Conversation

r9y9
Copy link
Contributor

@r9y9 r9y9 commented Apr 30, 2020

to give users control on the clamping behavior within the range [-1, 1], which was hardcoded before.

Fixes #596

r9y9 and others added 4 commits May 1, 2020 00:27
@r9y9
lfilter: add an optional arg clamp
308c290 
to give users control on the clamping behavior within the range [-1, 1],
which was hardcoded before.

Fixes pytorch#596
@vincentqb
doc string formatting
15a4145
@vincentqb
lint
1e60836
@vincentqb
doc string again
35aff51
vincentqb
vincentqb approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb vincentqb merged commit 0fcb0c0 into pytorch:master Apr 30, 2020
@r9y9 r9y9 deleted the fix-lfilter-clamp branch April 30, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lfilter: clamp in [-1, 1] to be optional
2 participants
@r9y9 @vincentqb