Allow zero momentum in Griffin-Lim #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
==========================================
+ Coverage 88.65% 88.66% +0.01%
==========================================
Files 21 21
Lines 2204 2206 +2
==========================================
+ Hits 1954 1956 +2
Misses 250 250
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to the docstring,
torchaudio.functional.griffinlim()currently requiresmomentum > 0. This PR fixes the code to requiremomentum >= 0, and also skips the momentum-related computation ifmomentumis a false-ish constant.Hats off to librosa for that momentum trick, by the way, hadn't seen it before. And thanks for porting it!