[BC Breaking] Reorganize C++ resources #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
libtorchaudio
branch
3 times, most recently
from
c9f754f
to
6219062
Compare
vincentqb
suggested changes
May 12, 2020
Ref: #636 |
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 21 21
Lines 2220 2220
=======================================
Hits 1972 1972
Misses 248 248
Continue to review full report at Codecov.
|
cpuhrsch
approved these changes
May 15, 2020
mthrok
changed the title
Done so. Thanks! |
bhargavkathivarapu
pushed a commit
to bhargavkathivarapu/audio
that referenced
this pull request
May 19, 2020
This PR
- Changes the location of C++ codes from
- from `torchaudio/torch_sox.cpp` to `torchaudio/csrc/sox.cpp`
- from `torchaudio/torch_sox.h` to `torchaudio/csrc/sox.h`
- Changes the location where the resulting library is placed
- from `_torch_sox.so` (outside of `torchaudio` module)
to `torchaudio/_torchaudio.so`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakdown of #625
This PR
torchaudio/torch_sox.cpptotorchaudio/csrc/sox.cpptorchaudio/torch_sox.htotorchaudio/csrc/sox.h_torch_sox.so(outside oftorchaudiomodule)to
torchaudio/_torchaudio.so.BTW: I noticed that
torch_sox.his not used by extension. We can remove it if we do not intend to make the extension library usable from external.