Adopt PyTorch's test util to torchscript test #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 21 21
Lines 2220 2220
=======================================
Hits 1972 1972
Misses 248 248 Continue to review full report at Codecov.
|
cpuhrsch
reviewed
May 14, 2020
cpuhrsch
reviewed
May 14, 2020
| @@ -209,7 +197,7 @@ def func(tensor): | |||
|
|
|||
| def test_lfilter(self): | |||
| if self.dtype == torch.float64: | |||
| pytest.xfail("This test is known to fail for float64") | |||
| raise unittest.SkipTest("This test is known to fail for float64") | |||
There was a problem hiding this comment.
I'd make this a decorator then and have separate tests for each dtype
There was a problem hiding this comment.
I think that's outside of the scope of this PR.
cpuhrsch
approved these changes
May 14, 2020
|
Following this PR, with pytorch 1.5.0 I get the following. I'm assuming this is only compatible with nighlties? |
offline follow-up with @mthrok -- yup. |
bhargavkathivarapu
pushed a commit
to bhargavkathivarapu/audio
that referenced
this pull request
May 19, 2020
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
scheduler.step() per epoch not per batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpuhrsch
Part 1 of PyTorch test framework adaptation. Applied to torchscript tests and some functional test.
If this looks good, I will expand the adaptation to other tests.