Make parameter optional string #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
==========================================
- Coverage 88.84% 88.80% -0.04%
==========================================
Files 21 21
Lines 2223 2225 +2
==========================================
+ Hits 1975 1976 +1
- Misses 248 249 +1
Continue to review full report at Codecov.
|
mthrok
reviewed
May 15, 2020
| @@ -376,7 +376,7 @@ def create_fb_matrix( | |||
| up_slopes = slopes[:, 2:] / f_diff[1:] # (n_freqs, n_mels) | |||
| fb = torch.max(zero, torch.min(down_slopes, up_slopes)) | |||
|
|
|||
| if norm == "slaney": | |||
| if norm is not None and norm == "slaney": | |||
There was a problem hiding this comment.
I think we should not allow values other than "slaney" or None to prevent the case where unintended value is passed, like typo.
|
@vincentqb Test needs to be fixed. |
mthrok
reviewed
May 26, 2020
test/torchscript_consistency_impl.py
Outdated
| @@ -83,7 +83,7 @@ def func(_): | |||
| f_max = 20.0 | |||
| n_mels = 10 | |||
| sample_rate = 16000 | |||
| norm = "" | |||
| norm = None | |||
There was a problem hiding this comment.
Rather than changing it to None, I suggest following the original suggestion of passing string value.
mthrok
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on comment