Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CUDA and CPU tests of torchscript_consistency #644

Merged
merged 1 commit into from May 15, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented May 15, 2020

Currently there is no CUDA device for regular FB's infra, where torchaudio's tests are ran.
Skipping these tests consistently raises a flag so we decided to split the tests into runnable and not-runnable on file-level.

@mthrok mthrok requested a review from cpuhrsch May 15, 2020 15:34
@cpuhrsch
Copy link
Contributor

Looks like there's some lint issues

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #644 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files          21       21           
  Lines        2223     2223           
=======================================
  Hits         1975     1975           
  Misses        248      248           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8187b4...ef1dce5. Read the comment docs.

@mthrok mthrok merged commit c960b11 into pytorch:master May 15, 2020
@mthrok mthrok deleted the test-split branch May 15, 2020 16:40
@mthrok mthrok mentioned this pull request May 17, 2020
bhargavkathivarapu pushed a commit to bhargavkathivarapu/audio that referenced this pull request May 19, 2020
Currently there is no CUDA device for regular FB's infra, where `torchaudio`'s tests are ran.
Skipping these tests consistently raises a flag so we decided to split the tests into runnable and not-runnable on file-level.
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Use PackedTensorAccessor32 in cpp extension tutorial
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants