-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bass with Biquad #661
Add Bass with Biquad #661
Conversation
Well done so far :)
|
Add the normalization coefficients
In test_sox_compatibility.py file, I add two bass tests: one test sets gain = 30, atol = 1e-4, the other sets gain = 40, atol = 1.5e-4. The details can be seen in pytorch#676
Add torchscript test
I update the code as below: Add the torchscript test. |
I update the files with flake8 check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! LGTM :)
The errors are flaky and unrelated to this PR. |
@jimchen90 -- can you add a link to the notebook you used for analysis here? |
I have added the link in the description. |
This is a sox dependency reduction task to implement bass (with biquad) filter as #260 using the treble (with biquad) filter as example.
Here is a notebook to compare the coefficients with SoX and Matlab audio toolbox.
A related issue #676