Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bass with Biquad #661

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Add Bass with Biquad #661

merged 5 commits into from
Jun 3, 2020

Conversation

jimchen90
Copy link
Contributor

@jimchen90 jimchen90 commented May 26, 2020

This is a sox dependency reduction task to implement bass (with biquad) filter as #260 using the treble (with biquad) filter as example.

Here is a notebook to compare the coefficients with SoX and Matlab audio toolbox.
A related issue #676

@vincentqb
Copy link
Contributor

vincentqb commented May 26, 2020

Well done so far :)

  • Let's add torchscript_consistency_test, see here.
  • Please add a description, with link to relevant issues and notebooks.
  • Tests are failling

@jimchen90 jimchen90 marked this pull request as ready for review June 2, 2020 17:34
Add the normalization coefficients
In test_sox_compatibility.py file, I add two bass tests: one test sets gain = 30, atol = 1e-4, the other sets gain = 40, atol = 1.5e-4. The details can be seen in pytorch#676
@jimchen90
Copy link
Contributor Author

jimchen90 commented Jun 2, 2020

I update the code as below:

Add the torchscript test.
In functional.py file, I use the normalized coefficients for biquad function.
In test_sox_compatibility.py file, I add two bass tests: one test sets gain = 30, atol = 1e-4, the other sets gain = 40, atol = 1.5e-4. The details can be seen in #676

@jimchen90 jimchen90 changed the title add bass with biquad Add Bass with Biquad Jun 2, 2020
@jimchen90
Copy link
Contributor Author

jimchen90 commented Jun 2, 2020

I update the files with flake8 check.
In test_sox_compatibility.py file, I add only one bass test with atol = 1.5e-4 instead of 1e-4 in treble test. The value atol = 1e-4 works if gain decreases (for example gain = 30)

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! LGTM :)

@vincentqb
Copy link
Contributor

The errors are flaky and unrelated to this PR.

@jimchen90 jimchen90 merged commit a466b3c into pytorch:master Jun 3, 2020
@vincentqb
Copy link
Contributor

@jimchen90 -- can you add a link to the notebook you used for analysis here?

@jimchen90
Copy link
Contributor Author

@jimchen90 -- can you add a link to the notebook you used for analysis here?

I have added the link in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants