Move I/O related Tensor ops to misc_ops module #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 89.19% 89.29% +0.10%
==========================================
Files 22 23 +1
Lines 2341 2335 -6
==========================================
- Hits 2088 2085 -3
+ Misses 253 250 -3
Continue to review full report at Codecov.
|
mthrok
changed the title
mthrok
force-pushed
the
module-utils
branch
2 times, most recently
from
4accd98
to
3d3e92d
Compare
* also deletes duplicated func
mthrok
changed the title
mthrok
changed the title
vincentqb
approved these changes
Jun 5, 2020
| @@ -0,0 +1,30 @@ | |||
| from typing import Union, Callable | |||
There was a problem hiding this comment.
nit: That's a very generic name for the file :)
There was a problem hiding this comment.
Yeah, I do not know what to call, but this is just evicting these functions from __init__.py so if this module glows into something then we can have a better naming.
|
Thanks! |
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
…onduct_file_exists Adding Code of Conduct file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_inputandaudio_normalizationfunctions defined in__init__.py,_backend.pyand_soundfilebackend(duplicated) are referred from multiple modules and cause cyclic module dependencies and preventing modularizing backends. This PR resolve this by putting them in a separate dedicated module_internal.misc_ops.Also change the helper function name from
audio_normalization(noun) tonormalize_audio(verb) for consistency.