Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SoX backend specific ops to _sox_backend module #695

Merged
merged 1 commit into from Jun 5, 2020
Merged

Move SoX backend specific ops to _sox_backend module #695

merged 1 commit into from Jun 5, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jun 4, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 4, 2020 •
edited

Codecov Report

Merging #695 into master will decrease coverage by 0.00%.
The diff coverage is 81.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
- Coverage   89.29%   89.28%   -0.01%     
==========================================
  Files          23       23              
  Lines        2335     2333       -2     
==========================================
- Hits         2085     2083       -2     
  Misses        250      250
Impacted Files Coverage Δ
torchaudio/_sox_backend.py 85.55% <81.03%> (-8.89%) ⬇️
torchaudio/__init__.py 92.00% <100.00%> (+8.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5eb485...9c9765a. Read the comment docs.

@mthrok mthrok changed the title Add proper modularization to sox backend Move SoX backend specific ops to _sox_backend module Jun 5, 2020
@mthrok mthrok force-pushed the module-sox branch 4 times, most recently from 5d3c43f to 202fd6f Compare June 5, 2020 19:18
@mthrok mthrok marked this pull request as ready for review June 5, 2020 21:31
@mthrok mthrok requested a review from vincentqb June 5, 2020 21:32
vincentqb
vincentqb approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok
Copy link
Collaborator Author

mthrok commented Jun 5, 2020

Thanks for the world-record approval speed.

@mthrok mthrok merged commit 4d52106 into pytorch:master Jun 5, 2020
@mthrok mthrok deleted the module-sox branch June 5, 2020 21:35
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
@soumith
Fix CrossEntropyLoss in transformers tutorial (pytorch#695)
809f27e 
Signed-off-by: David Pollack <david@i2x.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mthrok @vincentqb