Apply module availability guard to soundfile backend #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
module-soundfile
branch
2 times, most recently
from
4940d54
to
645412c
Compare
mthrok
changed the title
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
=======================================
Coverage 89.28% 89.29%
=======================================
Files 23 23
Lines 2333 2335 +2
=======================================
+ Hits 2083 2085 +2
Misses 250 250
Continue to review full report at Codecov.
|
mthrok
force-pushed
the
module-soundfile
branch
5 times, most recently
from
4f0eb28
to
28877e7
Compare
vincentqb
approved these changes
Jun 5, 2020
| from torchaudio._internal import misc_ops as _misc_ops | ||
| from torchaudio._internal import ( | ||
| module_utils as _mod_utils, | ||
| misc_ops as _misc_ops, |
There was a problem hiding this comment.
nit: this was like this before, but this is not used in the file at all?
There was a problem hiding this comment.
both of them are used. otherwise flake8 job would fail.
_misc_ops.check_input(src) is used in save function.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.