List backends dynamically based on availability #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 89.29% 89.24% -0.05%
==========================================
Files 23 23
Lines 2335 2343 +8
==========================================
+ Hits 2085 2091 +6
- Misses 250 252 +2
Continue to review full report at Codecov.
|
mthrok
force-pushed
the
backend
branch
9 times, most recently
from
8daca0d
to
a18ed45
Compare
vincentqb
approved these changes
Jun 8, 2020
| _BACKEND = 'soundfile' | ||
| if _mod_utils.is_module_available('torchaudio._torchaudio'): | ||
| _BACKENDS['sox'] = _sox_backend | ||
| _BACKEND = 'sox' |
There was a problem hiding this comment.
nit: here, "sox" would become the default since it's the last one selected
There was a problem hiding this comment.
Yes, that's the intension but it was a bit unusual so I updated to use regular if 'sox' else if 'soundfile', which is easier to read.
|
Thanks! |
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
* Update C++ DCGAN example for v1.4.0 * fix Reduction::Sum * FeatureDropout -> Dropout2d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.