Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put structs common to backends in backend.common #706

Merged
merged 1 commit into from Jun 9, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jun 8, 2020

It is strange that sox_backend depends on custom classes defined in soudfile_backend. This PR introduces backend.common module where these custom classes are defined and have both sox_backend and soundfile_backend depend on it.

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #706 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #706   +/-   ##
=======================================
  Coverage   89.28%   89.29%           
=======================================
  Files          24       25    +1     
  Lines        2342     2344    +2     
=======================================
+ Hits         2091     2093    +2     
  Misses        251      251           
Impacted Files Coverage Δ
torchaudio/backend/__init__.py 100.00% <100.00%> (ø)
torchaudio/backend/common.py 100.00% <100.00%> (ø)
torchaudio/backend/soundfile_backend.py 96.22% <100.00%> (-0.79%) ⬇️
torchaudio/backend/sox_backend.py 85.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e364289...ea18ecd. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review June 8, 2020 22:52
@mthrok mthrok requested a review from vincentqb June 8, 2020 22:52
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit b788db3 into pytorch:master Jun 9, 2020
@mthrok mthrok deleted the backend-common branch June 9, 2020 15:56
@mthrok
Copy link
Collaborator Author

mthrok commented Jun 9, 2020

Thanks!

@mthrok mthrok restored the backend-common branch June 9, 2020 15:59
@mthrok mthrok deleted the backend-common branch June 9, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants