Perform backend initialization in backend.__init__
#707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
backend-init
branch
2 times, most recently
from
8749477
to
15f3ebb
Compare
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 89.29% 89.23% -0.06%
==========================================
Files 25 25
Lines 2344 2351 +7
==========================================
+ Hits 2093 2098 +5
- Misses 251 253 +2
Continue to review full report at Codecov.
|
mthrok
changed the title
backend.__init__backend.__init__
vincentqb
approved these changes
Jun 9, 2020
| elif 'soundfile' in _BACKENDS: | ||
| _BACKEND = 'soundfile' | ||
| else: | ||
| warnings.warn('No audio backend is available.') |
There was a problem hiding this comment.
I agree that a warning is more appropriate.
|
Thanks! |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Brian Johnson <brianjo@fb.com> Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize backend in
backend.__init__.py.