Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer division #714

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fix integer division #714

merged 1 commit into from
Jun 11, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jun 11, 2020 •
edited

PyTorch started to raise errors when performing integer division with /. This PR fixes this with //.
Closes #713

@codecov
Copy link

codecov bot commented Jun 11, 2020 •
edited

Codecov Report

Merging #714 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files          27       27           
  Lines        2399     2399           
=======================================
  Hits         2139     2139           
  Misses        260      260
Impacted Files Coverage Δ
torchaudio/functional.py 95.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b5c80...469a92e. Read the comment docs.

@mthrok mthrok requested a review from vincentqb June 11, 2020 17:41
vincentqb
vincentqb approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok merged commit 50939b7 into pytorch:master Jun 11, 2020
@mthrok
Copy link
Collaborator Author

mthrok commented Jun 11, 2020

Thanks

@mthrok mthrok deleted the fix-div branch June 11, 2020 18:07
@mthrok mthrok mentioned this pull request Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integer division in test
2 participants
@mthrok @vincentqb