Get rid of dynamic test suite generation #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
fix-test-parameterization
branch
from
a801bc1
to
e79d6d3
Compare
`type` used in `common_utils` generates test class definition in `common_utils` and this modifies the module state after it's imported. This is anti-pattern. This PR get rid of the related utility functions and define test suite manually.
mthrok
force-pushed
the
fix-test-parameterization
branch
from
e79d6d3
to
23b0290
Compare
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
=======================================
Coverage 89.16% 89.16%
=======================================
Files 27 27
Lines 2399 2399
=======================================
Hits 2139 2139
Misses 260 260 Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeused incommon_utilsgenerates test class definition incommon_utilsandthis modifies the module state after it's imported. This is anti-pattern.
This PR get rid of the related utility functions and define test suite manually.
Follow up #712