Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wav2letter test #722

Merged
merged 1 commit into from Jun 16, 2020
Merged

Conversation

jimchen90
Copy link
Contributor

Update the variable locations in the test of wav2letter model. Variables are put inside the test definition.

@jimchen90 jimchen90 requested a review from vincentqb June 16, 2020 14:00
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please go ahead and merge this once the tests are all done running and green :)

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #722 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files          28       28           
  Lines        2467     2467           
=======================================
  Hits         2197     2197           
  Misses        270      270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f19c3...80f857d. Read the comment docs.

@jimchen90 jimchen90 merged commit ab733e7 into pytorch:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants