Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove in-place operations from GriffinLim for backprop #730

Merged
merged 1 commit into from Jun 18, 2020
Merged

Remove in-place operations from GriffinLim for backprop #730

merged 1 commit into from Jun 18, 2020

Conversation

pplantinga
Copy link
Contributor

@pplantinga pplantinga commented Jun 18, 2020 •
edited

Closes #729

mthrok
mthrok approved these changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mthrok mthrok requested a review from vincentqb June 18, 2020 18:44
vincentqb
vincentqb approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@vincentqb vincentqb merged commit bc1df48 into pytorch:master Jun 18, 2020
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
@brianjo
Merge pull request pytorch#730 from albanD/autograd_blitz
1fc4afb 
Update autograd blitz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthrok mthrok mthrok approved these changes

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torchaudio.transforms.GriffinLim does not allow backpropagation
3 participants
@pplantinga @mthrok @vincentqb