Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SignalInfo member name to frame #734

Merged
merged 1 commit into from Jun 23, 2020
Merged

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jun 19, 2020

This PR fixes the wrong member name of SignalInfo introduced in #718.

  • num_samples == num_frames * num_channels.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #734 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files          32       32           
  Lines        2527     2527           
=======================================
  Hits         2249     2249           
  Misses        278      278           
Impacted Files Coverage Δ
torchaudio/extension/extension.py 80.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fccd1...34878e1. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review June 20, 2020 00:07
@mthrok mthrok requested a review from vincentqb June 20, 2020 00:07
@mthrok mthrok mentioned this pull request Jun 20, 2020
6 tasks
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Relates to #618.

@mthrok mthrok merged commit e0f4c0e into pytorch:master Jun 23, 2020
@mthrok
Copy link
Collaborator Author

mthrok commented Jun 23, 2020

thanks

@mthrok mthrok deleted the fix-signal-info branch June 23, 2020 15:15
@mthrok mthrok restored the fix-signal-info branch June 23, 2020 23:14
@mthrok mthrok deleted the fix-signal-info branch June 23, 2020 23:36
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
Followed by pytorch#178 ;-)

Co-authored-by: Brian Johnson <brianjo@fb.com>
Co-authored-by: holly1238 <77758406+holly1238@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants