Add ogg/vorbis support to binary distribution #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
=======================================
Coverage 89.24% 89.24%
=======================================
Files 32 32
Lines 2519 2519
=======================================
Hits 2248 2248
Misses 271 271 Continue to review full report at Codecov.
|
mthrok
changed the title
Should we have a test for this?
As far as I know, the release is still a few weeks away :) |
Test is already there. |
6 tasks
Right :) |
|
Thanks! |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 29, 2020
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 29, 2020
mthrok
added a commit
that referenced
this pull request
Jun 29, 2020
* Add vorbis to binary build (#750) * Fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ogg/vorbis support to binary build.
@seemethere Can we slip this into the next release?
Solves #674