Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cmake for third party #753

Merged
merged 6 commits into from Jul 1, 2020
Merged

Use cmake for third party #753

merged 6 commits into from Jul 1, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jun 30, 2020 •
edited

This PR replaces the custom bash script for building codecs and libsox with CMake.
CMake gives better caching, secure fetching with much smaller numbers of lines of code.

@mthrok mthrok force-pushed the cmake branch 3 times, most recently from 804b0df to 75c62ac Compare June 30, 2020 15:20
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited

Codecov Report

Merging #753 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files          32       32           
  Lines        2517     2517           
=======================================
  Hits         2246     2246           
  Misses        271      271

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4daf2fb...296e9e0. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review June 30, 2020 20:21
seemethere
seemethere reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't mean we have to build with CUDA correct?

That'd open a whole can of worms if that's the case.

Otherwise lgtm

@mthrok
Copy link
Collaborator Author

mthrok commented Jun 30, 2020

This doesn't mean we have to build with CUDA correct?

Nope, this has nothing to do with CUDA, and torchaudio does not have any custom CUDA code.

@mthrok mthrok merged commit ea42513 into pytorch:master Jul 1, 2020
@mthrok mthrok deleted the cmake branch July 1, 2020 15:15
@mthrok
Copy link
Collaborator Author

mthrok commented Jul 1, 2020

Thanks!

mthrok added a commit to mthrok/audio that referenced this pull request Jul 1, 2020
@mthrok
Use cmake for third party (pytorch#753)
9c4b4f2 
* Use cmake for third party

* Apply patch to libmad

* Update gitignore

* Update docker test image
@mthrok mthrok mentioned this pull request Jul 2, 2020
Merged
mthrok added a commit that referenced this pull request Jul 6, 2020
@mthrok
Add OPUS support to 0.6 release (#763)
56aa954 
* Use cmake for third party (#753)

* Use cmake for third party

* Apply patch to libmad

* Update gitignore

* Update docker test image

* Add opus support (#755)
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
Merge pull request pytorch#753 from jianyuh/jlin27-quant-tutorials
2740556 
Update Dynamic Quant BERT Tutorial 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@vincentqb vincentqb Awaiting requested review from vincentqb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mthrok @seemethere