Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waveforms for Testing Purposes section to test/README.md #759

Merged
merged 6 commits into from Jul 8, 2020

Conversation

astaff
Copy link
Contributor

@astaff astaff commented Jul 1, 2020

This PR adds instructions around generating waveforms in tests from files and on the fly, as well as contributing new assets.

@astaff astaff requested a review from mthrok July 1, 2020 20:50
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #759   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          32       32           
  Lines        2617     2617           
=======================================
  Hits         2343     2343           
  Misses        274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180ede8...d09fdc8. Read the comment docs.

test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Show resolved Hide resolved
@mthrok
Copy link
Collaborator

mthrok commented Jul 1, 2020

Thanks for working on this!

test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vincentqb
Copy link
Contributor

(rebasing should fix unittest errors)

Artyom Astafurov and others added 6 commits July 8, 2020 12:46
use wrapper function for scipy.io.wavfile.read

Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
Rename variable

Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
@astaff astaff merged commit c375490 into pytorch:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants