New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Waveforms for Testing Purposes section to test/README.md #759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 32 32
Lines 2617 2617
=======================================
Hits 2343 2343
Misses 274 274 Continue to review full report at Codecov.
|
Thanks for working on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(rebasing should fix unittest errors) |
use wrapper function for scipy.io.wavfile.read Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
Rename variable Co-authored-by: moto <855818+mthrok@users.noreply.github.com>
This PR adds instructions around generating waveforms in tests from files and on the fly, as well as contributing new assets.