New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS CPU unittest #777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 32 32
Lines 2617 2617
=======================================
Hits 2343 2343
Misses 274 274 Continue to review full report at Codecov.
|
@mthrok So actually you are sharing the common script for unit tests between MacOS and Linux, right? |
Yeah, I thought of splitting them since I asked you to split Windows from Linux, but I felt that it's more beneficial to keep *nix systems same. (this is a vague line and subjective, splitting macOS and Linux feels like later when we need to apply changes to Linux, we might forget to apply the same changes to macOS) However, my goal is to add address sanitizer on macOS unit test, so depending on how it is done, I might split Linux and macOS later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's okay for me. But I'm just a bit worried that the same thing could happen to Windows, too.
Thanks! |
`test/test_sox_effects.py::Test_SoxEffectsChain::test_lowpass_speed` has some issue on our macOS CI, even though there was no issue at #777 . While we figure out the fix, we disable this test for macOS.
No description provided.