Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS CPU unittest #777

Merged
merged 5 commits into from Jul 14, 2020
Merged

Add macOS CPU unittest #777

merged 5 commits into from Jul 14, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jul 13, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #777 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          32       32           
  Lines        2617     2617           
=======================================
  Hits         2343     2343           
  Misses        274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9142fd...2f3c1f1. Read the comment docs.

@mthrok mthrok marked this pull request as ready for review July 13, 2020 21:59
@peterjc123
Copy link
Contributor

@mthrok So actually you are sharing the common script for unit tests between MacOS and Linux, right?

@mthrok
Copy link
Collaborator Author

mthrok commented Jul 14, 2020

@mthrok So actually you are sharing the common script for unit tests between MacOS and Linux, right?

Yeah, I thought of splitting them since I asked you to split Windows from Linux, but I felt that it's more beneficial to keep *nix systems same. (this is a vague line and subjective, splitting macOS and Linux feels like later when we need to apply changes to Linux, we might forget to apply the same changes to macOS) However, my goal is to add address sanitizer on macOS unit test, so depending on how it is done, I might split Linux and macOS later.

Copy link
Contributor

@peterjc123 peterjc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's okay for me. But I'm just a bit worried that the same thing could happen to Windows, too.

@mthrok
Copy link
Collaborator Author

mthrok commented Jul 14, 2020

That's okay for me. But I'm just a bit worried that the same thing could happen to Windows, too.

Yes, it's already happening. In #664 I forgot to remove style check from windows job, so I am doing it in #778 haha.

@mthrok mthrok merged commit f6dc2f6 into pytorch:master Jul 14, 2020
@mthrok
Copy link
Collaborator Author

mthrok commented Jul 14, 2020

Thanks!

@mthrok mthrok deleted the mac-unittest branch July 14, 2020 16:45
mthrok added a commit that referenced this pull request Jul 14, 2020
`test/test_sox_effects.py::Test_SoxEffectsChain::test_lowpass_speed` has some issue on our macOS CI, even though there was no issue at #777 .

While we figure out the fix, we disable this test for macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants