Remove frames_per_chunk argument from save #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pytorch#779, we plan to remove `frames_per_chunk` parameter from `save` function, but it will take some time before we can land pytorch#779, so we go ahead and remove the parameter first to reduce the conflict caused by interface change.
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
- Coverage 89.53% 89.49% -0.04%
==========================================
Files 32 32
Lines 2617 2617
==========================================
- Hits 2343 2342 -1
- Misses 274 275 +1
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #779, we plan to remove
frames_per_chunkparameter fromsavefunction, but it will take some time before we can land #779, so we go ahead and remove the parameter first to reduce the conflict caused by interface change.