Refactor test_sox_effects #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move misplaced sox compatibility test (T,Fade, T.Vol, T.Vad) to test/test_sox_compatibility.py 2. Move test_sox_effects to test/sox_effect/ where all the other functionalities from torchaudio.sox_effects are tested
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 35 35
Lines 2713 2713
=======================================
Hits 2438 2438
Misses 275 275 Continue to review full report at Codecov.
|
|
Thanks |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
* Fix txpos. * Fix further typo * Fix typo Co-authored-by: Brian Johnson <brianjo@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T,Fade,T.Vol,T.Vad) fromtest_sox_effects.pytotest_sox_compatibility.pytest_sox_effects.pytotest/sox_effect/where all the other functionalities fromtorchaudio.sox_effectsare tested