Avoid "-" symbol in test name #822
Conversation
Buck is not happy when test name contains "-" sign.
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 89.99% 89.95% -0.04%
==========================================
Files 35 35
Lines 2719 2719
==========================================
- Hits 2447 2446 -1
- Misses 272 273 +1
Continue to review full report at Codecov.
|
| @@ -62,7 +62,7 @@ def test_wav(self, dtype, sample_rate, num_channels): | |||
| [8000, 16000], | |||
| [1, 2], | |||
| [-4.2, -0.2, 0, 0.2, 96, 128, 160, 192, 224, 256, 320], | |||
| )), name_func=name_func) | |||
| ))) | |||
There was a problem hiding this comment.
Can you clarify how this is working around the issue?
There was a problem hiding this comment.
parameterized by default generates simple test names like test_foo_1, test_foo_2, test_foo_3 ...
but since I generate a whole lot of tests, this default naming convention is not very helpful when some of them fail on CI. name_func here changes the naming convention to simply stringify parameters and concatenate them as test name, which is why "-" symbol is included in the test name.
The code change in this PR gives up the custom naming function and use the default naming convention.
There was a problem hiding this comment.
Good to know. Are you intentionally leaving some of the custom naming conventions in the other functions?
There was a problem hiding this comment.
Yes, they work well in places other than buck or as long as "-" symbol is not included
|
thanks |
Remove PyTorch 1.2 notes in tutorials
Buck is not happy when test name contains "-" symbol, and it fails to run these tests.