Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify C++ registration with TORCH_LIBRARY #840

Merged
merged 1 commit into from Aug 7, 2020
Merged

Simplify C++ registration with TORCH_LIBRARY #840

merged 1 commit into from Aug 7, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jul 29, 2020 •
edited

This PR replaces the raw PyTorch C++ registration mechanism with TORCH_LIBRARY macro.

@codecov
Copy link

codecov bot commented Jul 29, 2020 •
edited

Codecov Report

Merging #840 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files          35       35           
  Lines        2719     2719           
=======================================
  Hits         2447     2447           
  Misses        272      272

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870811c...bcc4041. Read the comment docs.

@mthrok mthrok force-pushed the torch-library branch 8 times, most recently from d8b8ccc to 8f4e1a1 Compare August 5, 2020 21:11
@mthrok mthrok mentioned this pull request Aug 6, 2020
Merged
@mthrok mthrok marked this pull request as ready for review August 6, 2020 18:56
@mthrok mthrok requested a review from vincentqb August 6, 2020 19:03
vincentqb
vincentqb approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is cleaner :)

@mthrok mthrok merged commit e344e45 into pytorch:master Aug 7, 2020
@mthrok mthrok deleted the torch-library branch August 7, 2020 19:13
@mthrok
Copy link
Collaborator Author

mthrok commented Aug 7, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mthrok @vincentqb