Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify fastNLP to work with latest and older torchtext releases #142

Closed
wconstab opened this issue Oct 21, 2020 · 1 comment
Closed

Modify fastNLP to work with latest and older torchtext releases #142

wconstab opened this issue Oct 21, 2020 · 1 comment
Projects
Benchmark Issues

Comments

@wconstab
Copy link
Contributor

torchtext 0.8.0 release moved AG_NEWS from datasets.experimental. to datasets. fastNLP should be able to run under new and old torchtext for the sake of running historical builds, so we can check the torchtext version in the fastNLP init.py and conditionally import the right name.
wconstab added a commit that referenced this issue Oct 29, 2020
@wconstab @malfet
Modify AG_NEWS import to work under new and old torchtext #142 (#143)
ac7a531 
* Modify AG_NEWS import to work under new and old torchtext

torchtext >=0.8.0 moved AG_NEWS from experimental to mainline

* Update torchbenchmark/models/fastNLP/__init__.py

Co-authored-by: Nikita Shulga <nshulga@fb.com>
@wconstab wconstab added this to Issues with current models in Benchmark Issues Nov 17, 2020
xuzhao9 pushed a commit that referenced this issue Jun 21, 2021
@wconstab @malfet @xuzhao9
Modify AG_NEWS import to work under new and old torchtext #142 (#143)
50e1206 
* Modify AG_NEWS import to work under new and old torchtext

torchtext >=0.8.0 moved AG_NEWS from experimental to mainline

* Update torchbenchmark/models/fastNLP/__init__.py

Co-authored-by: Nikita Shulga <nshulga@fb.com>
@xuzhao9
Copy link
Contributor

xuzhao9 commented Jun 21, 2021

Cherry-picked the fix to 0.1 branch

@xuzhao9 xuzhao9 closed this as completed Jun 22, 2021
Benchmark Issues automation moved this from Issues with current models to Done Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Benchmark Issues
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuzhao9 @wconstab