Make train_Yvar optional in MultiTaskGP and deprecate FixedNoiseMultiTaskGP #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TaskGP Summary: There's no real reason to have two separate models when the only difference is the likelihood. This helps clean up some of the hacky inheritance with SAAS MTGP as well. Reviewed By: esantorella Differential Revision: D45629140 fbshipit-source-id: 3133ba3ac6af3e8bcda6ef503ef52a4538435aca
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45629140 |
Codecov Report
@@ Coverage Diff @@
## main #1818 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14915 14910 -5
=========================================
- Hits 14915 14910 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request has been merged in 7d275ae. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
May 1, 2024
Summary: Deprecated since pytorch#1818. `MultiTaskGP` offers the full functionality of `FixedNoiseMultiTaskGP` without requiring a different class. Reviewed By: dme65 Differential Revision: D56802249
facebook-github-bot
pushed a commit
that referenced
this pull request
May 1, 2024
Summary: Deprecated since #1818. `MultiTaskGP` offers the full functionality of `FixedNoiseMultiTaskGP` without requiring a different class. Reviewed By: dme65 Differential Revision: D56802249 fbshipit-source-id: 44b07d2a1b5551346871a9f8b36ca069b9280019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There's no real reason to have two separate models when the only difference is the likelihood. This helps clean up some of the hacky inheritance with SAAS MTGP as well.
Reviewed By: esantorella
Differential Revision: D45629140