Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated botorch/generation/gen/minimize #2229

Closed
wants to merge 2 commits into from

Conversation

saitcakmak
Copy link
Contributor

Summary: This has been deprecated since #1352.

Differential Revision: D54280813

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 27, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54280813

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (fbb460d) to head (bbe5943).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
- Coverage   99.87%   99.87%   -0.01%     
==========================================
  Files         188      188              
  Lines       16739    16722      -17     
==========================================
- Hits        16718    16701      -17     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54280813

Summary: These have been deprecated since 0.8.0, time to let them go.

Reviewed By: Balandat

Differential Revision: D54280379
Summary: This has been deprecated since pytorch#1352.

Reviewed By: Balandat

Differential Revision: D54280813
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54280813

@Balandat
Copy link
Contributor

Balandat commented Mar 3, 2024

Merged as 5b9a85d

@Balandat Balandat closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants