Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remap task values in MTGP if they are not contiguous integers starting from zero #2230

Closed
wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

Summary: see title. This handles cases where the task values are e.g. {0,2}.

Reviewed By: saitcakmak

Differential Revision: D54121693

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54121693

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (5b9a85d) to head (a062311).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2230   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files         188      188           
  Lines       16722    16741   +19     
=======================================
+ Hits        16701    16720   +19     
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54121693

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54121693

…g from zero

Summary: see title. This handles cases where the task values are e.g. {0,2}.

Reviewed By: saitcakmak

Differential Revision: D54121693
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54121693

@Balandat
Copy link
Contributor

Balandat commented Mar 3, 2024

merged as bdd3708

@Balandat Balandat closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants