Reap base_samples argument of GPyTorchPosterior.rsample #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55038429 |
Summary: The `base_samples` argument to GPyTorchPosterior.rsample was deprecated in BoTorch 8.0.0 - reaped the deprecated code - removed the corresponding unit tests - Removed `base_samples` argument from `MockPosterior.rsample` used for testing, since the base Posterior class also does not permit `base_samples` in `rsample`. Moved an exception in `MockPosterior` so that invalid `base_samples` will still be checked. - fixed a docstring in PosteriorList Differential Revision: D55038429
esantorella
force-pushed
the
export-D55038429
branch
from
f99ed3f
to
a66dfa7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55038429 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 197 197
Lines 17163 17154 -9
==========================================
- Hits 17159 17150 -9
Misses 4 4 ☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Mar 19, 2024
Summary: X-link: facebookexternal/botorch_fb#17 The `base_samples` argument to GPyTorchPosterior.rsample was deprecated in BoTorch 8.0.0 - reaped the deprecated code - removed the corresponding unit tests - Removed `base_samples` argument from `MockPosterior.rsample` used for testing, since the base Posterior class also does not permit `base_samples` in `rsample`. Moved an exception in `MockPosterior` so that invalid `base_samples` will still be checked. - fixed a docstring in PosteriorList Reviewed By: saitcakmak Differential Revision: D55038429
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Mar 19, 2024
Summary: X-link: facebookexternal/botorch_fb#17 The `base_samples` argument to GPyTorchPosterior.rsample was deprecated in BoTorch 8.0.0 - reaped the deprecated code - removed the corresponding unit tests - Removed `base_samples` argument from `MockPosterior.rsample` used for testing, since the base Posterior class also does not permit `base_samples` in `rsample`. Moved an exception in `MockPosterior` so that invalid `base_samples` will still be checked. - fixed a docstring in PosteriorList Reviewed By: saitcakmak Differential Revision: D55038429
|
This pull request has been merged in 4545f98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
base_samplesargument to GPyTorchPosterior.rsample was deprecated in BoTorch 8.0.0base_samplesargument fromMockPosterior.rsampleused for testing, since the base Posterior class also does not permitbase_samplesinrsample. Moved an exception inMockPosteriorso that invalidbase_sampleswill still be checked.Differential Revision: D55038429