Make cross-validation test less repetitive and add device and dtype checks #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55572962 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Mar 31, 2024
…hecks (pytorch#2268) Summary: - Deduplicated logic between the cases with and without noise observations - Broke up into subtests - Added checks for Yvar produced by cross-validation - Added checks for device and dtype of results Differential Revision: D55572962
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Mar 31, 2024
…hecks (pytorch#2268) Summary: - Deduplicated logic between the cases with and without noise observations - Broke up into subtests - Added checks for Yvar produced by cross-validation - Added checks for device and dtype of results Differential Revision: D55572962
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 197 197
Lines 17148 17148
=======================================
Hits 17144 17144
Misses 4 4 ☔ View full report in Codecov by Sentry. |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Mar 31, 2024
…hecks (pytorch#2268) Summary: - Deduplicated logic between the cases with and without noise observations - Broke up into subtests - Added checks for Yvar produced by cross-validation - Added checks for device and dtype of results Reviewed By: Balandat Differential Revision: D55572962
esantorella
force-pushed
the
export-D55572962
branch
from
50b7de3
to
d42a982
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55572962 |
…hecks (pytorch#2268) Summary: - Deduplicated logic between the cases with and without noise observations - Broke up into subtests - Added checks for Yvar produced by cross-validation - Added checks for device and dtype of results Reviewed By: Balandat Differential Revision: D55572962
esantorella
force-pushed
the
export-D55572962
branch
from
d42a982
to
78290ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55572962 |
|
This pull request has been merged in ad848f6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D55572962