-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESS: Allowing diagonal covariance root with fixed indices #2283
Conversation
This pull request was exported from Phabricator. Differential Revision: D55808235 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 197 197
Lines 17165 17156 -9
=======================================
- Hits 17160 17152 -8
+ Misses 5 4 -1 ☔ View full report in Codecov by Sentry. |
c6d73c8
to
6847151
Compare
This pull request was exported from Phabricator. Differential Revision: D55808235 |
Summary: This commit adds support for a diagonal covariance root in conjunction with fixed indices for ESS. This is not generally supported, as the root would have to be re-factorized. The diagonal case allows for an efficient implementation without re-factorization. Differential Revision: D55808235
6847151
to
fb43775
Compare
This pull request was exported from Phabricator. Differential Revision: D55808235 |
fb43775
to
35f561e
Compare
Summary: This commit adds support for a diagonal covariance root in conjunction with fixed indices for ESS. This is not generally supported, as the root would have to be re-factorized. The diagonal case allows for an efficient implementation without re-factorization. Reviewed By: Balandat Differential Revision: D55808235
This pull request was exported from Phabricator. Differential Revision: D55808235 |
Summary: This commit adds support for a diagonal covariance root in conjunction with fixed indices for ESS. This is not generally supported, as the root would have to be re-factorized. The diagonal case allows for an efficient implementation without re-factorization. Reviewed By: Balandat Differential Revision: D55808235
35f561e
to
036c5c1
Compare
This pull request was exported from Phabricator. Differential Revision: D55808235 |
This pull request has been merged in 7c28a20. |
Summary: This commit adds support for a diagonal covariance root in conjunction with fixed indices for ESS. This is not generally supported, as the root would have to be re-factorized. The diagonal case allows for an efficient implementation without re-factorization.
Differential Revision: D55808235